Commit 974defd3 authored by Ilya Rassadin's avatar Ilya Rassadin
Browse files

Switched from needs to dependencies 

needs keyword bypasses stage prerequisites and deploy will happen earlier then test will be finished.
This is a mistake, we shouldn't deploy anything if we define tests and they are red.
parent b111bd40

.deploy_code_to_server.yml

+4 −6
Original line number Diff line number Diff line
@@ -2,9 +2,8 @@ 
  extends: .before_deploy_code

  script:

    - rsync --links --safe-links-avz --chown=$user:$group -e "ssh $SSH_OPTS" $CI_PROJECT_DIR/www/ $DEPLOY_HOST_PATH/www/

  needs:

    - job: setup_environment_vars

      artifacts: true

  dependencies:

    - setup_environment_vars

  only:

    refs:

    - beta
@@ -36,9 +35,8 @@ 
  after_script:

    - if [ $PROJECT_CMS_TYPE = bitrix ] && [ $SKIP_SETTINGS_EXTRA_DEPLOYMENT != true ]; then curl -o /tmp/.settings_extra.php https://gitlab.cetera.ru/boilerplate/ci/raw/master/.settings_extra.php; fi

    - if [ $PROJECT_CMS_TYPE = bitrix ] && [ $SKIP_SETTINGS_EXTRA_DEPLOYMENT != true ]; then rsync -avz --chown=$user:$group -e "ssh $SSH_OPTS" /tmp/.settings_extra.php $DEPLOY_HOST_PATH/www/bitrix/; fi

  needs:

    - job: setup_environment_vars

      artifacts: true

  dependencies:

    - setup_environment_vars

  only:

    refs:

    - beta

.deploy_composer_files_to_server.yml

+3 −5
Original line number Diff line number Diff line
@@ -7,11 +7,9 @@ 


.deploy_composer_files_to_server:

  extends: .before_deploy_code

  needs:

    - job: build_composer

      artifacts: true

    - job: setup_environment_vars

      artifacts: true

  dependencies:

    - build_composer

    - setup_environment_vars

  variables:

    COMPOSER_SERVER_DIR: vendor/

  script: